Tuesday, April 21, 2015

AutoMapper Anti-patterns

I think AutoMapper is evil. It just makes it too easy to do things you should not be doing.

Over the past 4 years I've worked with AutoMapper on several projects and collected a bunch of anti-patterns.

 

Automapper 101

When you see repetitive code appear in a mapping profile this is a sure sign you're not 'doing it right'. For example every mapping from DateTime to string explicitly states that it should use the short date format.

Automapper supports powerful methods of cleaning up the way you map your data. 

Solution

Learn how to use AutoMapper before using it in production code.

Define once how to convert one data type into another (e.g. DateTime to string) so you don't need to repeat that everywhere.

 

Empty profile validation

Create a profile but register every mapping in the global namespace.

Then assert the profile is valid. You are essentially validating an empty profile.

Solution

Don't ever call AutoMapper.CreateMap from an AutoMapper profile, use the instance methods instead.

public class BadProfile: Profile
{
   public override string ProfileName { get { return "BadProfile"; } }
   
   protected override void Configure()
   {
      // !!! Do not do this! It registers the mapping globally !!!
      AutoMapper.CreateMap<DTO.SomeAggregate, Model.SomeAggregate>();
   }
}
public class GoodProfile: Profile
{
   public override string ProfileName { get { return "GoodProfile"; } }
   
   protected override void Configure()
   {
      // Always use the methods on the profile to register mappings
      CreateMap<DTO.SomeAggregat, Model.SomeAggregate>();
   }
}

 

Wait to validate

Credits go to Bastiaan de Rijber for this one.

Asserting profile validity is expensive. If you do this at application startup you may get a serious delay on application startup.

Solution

Assert profile validity in a unit test.

 

Automap all the things

automap-all-the-thingsWhen using automapper is a reflex, it will work against you.

Automapper was intended to reduce repetitive code for mapping types that are highly similar.

If you use it for everything you'll end up with HUGE profiles that are usually more complex than straight up hand-coded mappings.

Solution

Use AutoMapper to get rid of dumb 1-on-1 mappings and simple projections, for example from a primitive type to a localized string.

The rabbit hole

It's easy to build up a mapping profile for a complex data structure like an aggregate root. But keep in mind that when you change your model you will need to untangle the mappings to see which are actually used and where. Since you lost the ability to trace how data is connected due to AutoMappers loose coupling, you'll find yourself in a swamp and sinking fast.

Solution

Keep your mappings simple and your mapping profiles limited in size.

 

Resolvers galore

Building resolvers to do simple mappings is a bad idea. The resolvers add a layer of obscurity to the already loosly coupled mappings. It's all too easy to start hitting the database in these mappings and before you know it you get spanked by N+1 issues.

Solution

If your mapping is more complex than a single expression but it does not involve loading entities create a method for it on the profile or add an extension method that you can reuse. This will prevent obscuring the mapping code in yet another class.

If you do need to load stuff from the database to perform the mapping, seriously reconsider whether AutoMapper is the right tool for the job.

You may be better of coding this by hand using a proper ORM (that's what they are for).

 

'Intelligent' mapping

Resolvers open up a doorway to make your mappings 'intelligent'. This is where resolvers get more and more complexity and soon all sorts of complicated logic starts to creep into the mappings. This smell turns into an outright stink when entities are being created in the resolvers. The net result is that the mappings go from magical to dark voodoo and you find yourself writing unit tests that need to initialize AutoMapper and stub out a bunch of services in order to check the validity of the mapping. A world of hurt.

Solution

Just don't do it. Mapping should always be straight forward.

 

Let me reconfigure that for ya

As mentioned before, setting up mappings is costly. This means you need to think carefully about when you perform that configuration. Once you understand that it’s easy to see that reconfiguring AutoMapper on every, single, call to a service is a bad idea.

Solution

Initialize your mappings once, and once only.

Monday, April 20, 2015

AutoMapper is evil

tl;dr Automapper kills traceability making software maintenance increasingly difficult. It's also a gateway drug to a bunch of anti-patterns.

I've turned from an AutoMapper advocate to a strong opponent over the course of about a year.

At first it seems like a great way to reduce stupid repetitive code. It accelerates initial development.

All is good and well until you have to change the application and all the nice tooling that helps us refactor with confidence breaks down because it cannot see the implicit coupling between mapped objects.

Compiler checks are gone.

Traceability is gone.

Debugging is next to impossible.

Profile validation to the rescue?

AutoMapper allows you to mitigate this to some extent by grouping mappings into profiles and then asserting that the profile is valid, meaning that all properties of the destination types are mapped.

This however requires that any unused properties in the destination type are ignored. If mappings address only a subset of fields on your types this will lead to lots of custom configuration code in your mappings, essentially defeating the main benefit of AutoMapper: less mapping code.

AutoMapper is not free

AutoMapper was hailed by some as the solution to ease the implementation of strictly layered architectures and later DDD. Decoupling layers or domains is impossible without mapping or transforming from one model to the next.

While AutoMapper can indeed help ease that burden, I'm inclined to agree with Greg Young that all this mapping is painful and if you really want to do this, you should feel that pain.(See 8 lines of code by Greg Young, skip to 39:00 for the bit about AutoMapper)

All that mapping magic does not come for free. Besides the maintenance issues mentioned earlier, AutoMapper also has a performance cost.

Setting up a lot of mappings is expensive as expressions need to be compiled on startup. Once that is done, AutoMapper is still nowhere near as fast as straight up hand written assignments.

Have a look at the performance comparison offered by AutoMapper alternative FastMapper (FastMapper on CodePlex, scroll all the way down for the performace comparison).

In an average application a bit of AutoMapper won't hurt, but once load increases it can definitely start to make a difference. A concrete case I saw was in a message driven application where large volumes of messages were being transferred during upgrades on deployment of new releases. Performance analysis showed that AutoMapper consumed between 10 and 20% of the CPU time. 

A final word

I have stopped using AutoMapper completely and have not regretted that once. Hand authored mapping code is faster, easier to understand and easier to maintain.

Thursday, March 19, 2015

Tweaking web.config for startup performance

I was faced recently with slow application startup for any ASP.NET based application on a brand spanking new Windows 2012 VM.

Some quick analysis showed that static content was served up fast, even on the first hit. However anything going through the managed pipeline would take up to 23 seconds for the first hit. That’s quite a lot for a simple index.html file that would serve in 10 to 30ms when treated as static content.

Initial investigation made it unlikely that the hardware and/or VM was the problem. So the next likely candidate is the ASP.NET pipeline initialization.

Looking at the ASP.NET handlers installed by default, there is a pile of stuff there that this particular customer doesn’t (and won’t) use.image

Clearing out all but some essential handlers dramatically reduced the time-to-first data for the initial request. But, a bunch of these handlers are there for good reason. For example to protect sensitive files.

Pingfu to the rescue

For production use, Pingfu did the hard work already and came up with a list of handlers that can safely be removed for ASP.NET 4.x sites in integrated mode. Originally, this list is intended to reduce the attack surface of an ASP.NET application but it has the happy side effect of reducing application startup times by 10 to 12 seconds.

Monday, September 29, 2014

The 10 commandments of software development

A couple of weeks ago fellow senior Bastiaan de Rijber and I were venting some frustration on Skype. We realized that we find ourselves repeating the same tidbits of wisdom over and over again to developers in conversations, code reviews and post mortems on failures, big and and small.

I’ll admit the title seems a bit ‘holier-than-thou’ so I’m going to stick to the theme and do this all biblical style:

  1. Thou shall not assume, for assumptions are the mother of all fuckups
  2. Thou shall not blame the tooling, for it's probably thou who has made the mistake
  3. Thou shall clean up thy shit, for there is no greater pleasure than deleting code
  4. Thou shall not optimize prematurely, for premature optimization is the root of all evil
  5. Thou must find the root cause before applying the 'fix'
  6. Thou shall not practice the black art of multi threading without Jedi assistance
  7. Thou shall not commit shortly before going home/on vacation/to sleep
  8. Thou shall review thy code before committing
  9. Thou shall not proclaim the obvious in comments
  10. Thou shall not claim 'It works on my machine'

Of course we have a bunch more of these…